feat: build macOS binaries natively for V8 code cache#1014
Merged
Conversation
Contributor
Codecov Results 📊✅ Patch coverage is 100.00%. Project has 4236 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 81.87% 81.87% —%
==========================================
Files 328 328 —
Lines 23359 23359 —
Branches 15114 15114 —
==========================================
+ Hits 19123 19123 —
- Misses 4236 4236 —
- Partials 1621 1621 —Generated by Codecov Action |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Build darwin-arm64 on macos-latest and darwin-x64 on macos-13 instead of cross-compiling from ubuntu-latest. This enables fossilize's V8 code cache for macOS binaries (~15% faster startup). Also enables native smoke tests for darwin-arm64 (can-test: true). rcodesign setup is now platform-aware with SHA256-pinned binaries for Linux (x86_64-musl), macOS arm64, and macOS x64.
BYK
force-pushed
the
feat/macos-native-build
branch
from
78a341e to
a97c33b
Compare
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
There are 3 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a97c33b. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Build macOS binaries natively instead of cross-compiling from Linux. This enables fossilize 0.6.0's V8 code cache for macOS binaries, giving ~15% faster startup.
Changes
Build matrix:
darwin-arm64:ubuntu-latest→macos-latest(arm64, can smoke test)darwin-x64:ubuntu-latest→macos-13(last Intel runner)Codesign setup:
shasum -a 256 -cworks on both Linux and macOS (replacessha256sum)Code cache coverage after this PR