chore: update fossilize to 0.8.1 (fix cross-compile strip crash)#1038
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8023d85. Configure here.
fossilize 0.8.1 fixes a bug where strip failure on cross-compiled binaries (e.g., linux-arm64 on x86_64 host) called process.exit() instead of falling through as non-fatal. This caused the linux-arm64 build to fail on every main push.
BYK
force-pushed
the
chore/fossilize-0.8.1
branch
from
8023d85 to
1b81781
Compare
Contributor
Codecov Results 📊✅ Patch coverage is 100.00%. Project has 4301 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
- Coverage 82.00% 81.99% -0.01%
==========================================
Files 329 329 —
Lines 23806 23883 +77
Branches 15543 15603 +60
==========================================
+ Hits 19522 19582 +60
- Misses 4284 4301 +17
- Partials 1643 1650 +7Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates fossilize to 0.8.1 which fixes a bug where
stripfailure on cross-compiled binaries (e.g., linux-arm64 on x86_64 host) calledprocess.exit()instead of falling through as non-fatal.This was a pre-existing issue that predates #1037 — the
run()helper in fossilize has always calledprocess.exit()for numeric error codes, bypassing the try/catch. The fix usesexecFileAsyncdirectly so the error is properly caught and treated as non-fatal (prints a warning and continues with an unstripped binary).Upstream: BYK/fossilize#21