-
-
Notifications
You must be signed in to change notification settings - Fork 1
feat(telemetry): add is_self_hosted tag #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
Documentation 📚
🤖 This preview updates automatically when you update the PR. |
Codecov Results 📊✅ Patch coverage is 100.00%. Project has 2027 uncovered lines. Files with missing lines (27)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 68.30% 68.30% —%
==========================================
Files 55 55 —
Lines 6395 6395 —
Branches 0 0 —
==========================================
+ Hits 4368 4368 —
- Misses 2027 2027 —
- Partials 0 0 —Generated by Codecov Action |
4a45717 to
13b0169
Compare
Add a boolean tag to Sentry telemetry to distinguish between SaaS and self-hosted Sentry instances. Also consolidates URL utilities: - Move isSentrySaasUrl to sentry-urls.ts (canonical location) - Remove duplicate DEFAULT_SENTRY_URL from sentry-urls.ts (use constants.ts) - Remove getDefaultBaseUrl and isSentrySaasUrl from region.ts (use sentry-urls.ts)
13b0169 to
03ae0cf
Compare
|
@sentry review |
|
@cursor review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Summary
Adds an
is_self_hostedboolean tag to Sentry telemetry to distinguish between SaaS and self-hosted instances.Changes
is_self_hostedtag ininitSentry()based onSENTRY_URLconfigurationsentry-urls.ts:isSentrySaasUrlfromregion.tstosentry-urls.tsDEFAULT_SENTRY_HOSTfromconstants.ts(removes duplicate)getDefaultBaseUrlandisSentrySaasUrlfromregion.tsBehavior
is_self_hostedhttps://sentry.io)falsehttps://us.sentry.iofalsehttps://sentry.mycompany.comtrue