ci: rename CI workflow to Build and fix artifact filter #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Cli
Other
Bug Fixes 🐛Upgrade
Other
Documentation 📚
Internal Changes 🔧Ci
Other
Other🤖 This preview updates automatically when you update the PR. |
Craft's GitHub artifact provider matches the artifact config keys against the workflow run's name field, not the filename. Our config used `ci.yml` (the filename) but the workflow declared `name: CI`, so no runs matched and artifact retrieval failed after 3 retries. Rename the workflow from `CI` to `Build` which better describes its purpose, and update `.craft.yml` to match.
BYK
force-pushed
the
fix/craft-workflow-filter
branch
from
b12340f to
f0e6150
Compare
BYK
changed the title
Contributor
Codecov Results 📊✅ Patch coverage is 100.00%. Project has 3871 uncovered lines. Files with missing lines (67)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 69.85% 69.85% —%
==========================================
Files 105 105 —
Lines 12841 12841 —
Branches 0 0 —
==========================================
+ Hits 8970 8970 —
- Misses 3871 3871 —
- Partials 0 0 —Generated by Codecov Action |
BYK
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
BYK
added a commit
to getsentry/sentry-python
that referenced
this pull request
Feb 10, 2026
Craft's GitHubArtifactProvider.filterWorkflowRuns() matches config keys against the workflow's name field, not the filename. The key 'ci.yml' would never match the workflow named 'CI', causing artifact retrieval to fail. Ref: getsentry/cli#229
BYK
changed the title
This was referenced Feb 11, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Publishing with craft fails because the artifact filter key in
.craft.ymlused the workflow filename (ci.yml) instead of the workflow name field. Craft'sGitHubArtifactProvider.filterWorkflowRuns()matches config keys againstrun.name, so the filterci.yml(regex/^ci\.yml$/) never matched"CI", causing artifact retrieval to fail after 3 retries.Changes
CItoBuild.craft.ymlartifact filter key fromci.ymltoBuild