fix(upgrade): check GHCR for nightly version existence instead of GitHub Releases#352
Merged
fix(upgrade): check GHCR for nightly version existence instead of GitHub Releases#352
Conversation
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Trace
Other
Bug Fixes 🐛Api
Formatters
Setup
Upgrade
Other
Documentation 📚
Internal Changes 🔧Api
Other
🤖 This preview updates automatically when you update the PR. |
Contributor
Codecov Results 📊✅ 101 passed | Total: 101 | Pass Rate: 100% | Execution Time: 0ms 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ✅ Patch coverage is 88.89%. Project has 3683 uncovered lines. Files with missing lines (1)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 80.66% 80.67% +0.01%
==========================================
Files 127 127 —
Lines 19028 19052 +24
Branches 0 0 —
==========================================
+ Hits 15348 15369 +21
- Misses 3680 3683 +3
- Partials 0 0 —Generated by Codecov Action |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
ae992b9 to
a33cb6c
Compare
…Hub Releases Fixes CLI-B5 When a user pins a specific nightly version (e.g. `sentry cli upgrade 0.14.0-dev.1772661724`), the `versionExists()` function was checking GitHub Releases (which only has stable releases). Nightly builds are published to GHCR with tags like `nightly-0.14.0-dev.1772661724`. Changes: - Route nightly version checks to GHCR via `fetchManifest()` instead of GitHub Releases, so pinned nightly upgrades no longer fail with a false "Version X not found" error - Propagate network errors from GHCR (only 404/403 returns false) - Pass pinned version to `downloadNightlyToPath()` so the correct versioned tag is fetched instead of the rolling :nightly tag
a33cb6c to
ad01e1e
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes CLI-B5
When a user pins a specific nightly version (e.g.
sentry cli upgrade 0.14.0-dev.1772661724), theversionExists()function was checking GitHub Releases — which only has stable releases. Nightly builds are published to GHCR with versioned tags likenightly-0.14.0-dev.1772661724, so the check always returned 404 and threw a falseUpgradeError: Version X not found.Changes
nightlyVersionExists()helper that checks GHCR for the versioned nightly tag via anonymous token exchange + manifest fetch (2 HTTP requests)versionExists()to route nightly versions (detected viaisNightlyVersion()) to GHCR instead of GitHub Releases/npmUpgradeError— only 404/403 returns false (consistent with stable version checks)downloadNightlyToPath()now accepts an optionalversionparameter to fetch the pinned versioned tag instead of always using the rolling:nightlytag