test: use --timeout CLI flag for model-based test timeouts#367
Merged
Conversation
bunfig.toml's timeout key is not supported by Bun 1.3.x — it silently has no effect, leaving all tests at the default 5000ms per-test timeout. Model-based tests (50 iterations × full SQLite schema init × 10-30 command sequences) routinely need 5-13s per test, causing intermittent failures. Changes: - Remove non-functional timeout=30000 from bunfig.toml - Add --timeout 15000 to test:unit, test:isolated, test:e2e scripts - Document the bunfig.toml timeout gotcha in AGENTS.md
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
Contributor
Codecov Results 📊✅ 104 passed | Total: 104 | Pass Rate: 100% | Execution Time: 0ms 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 3870 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 81.02% 81.23% +0.21%
==========================================
Files 129 130 +1
Lines 20363 20621 +258
Branches 0 0 —
==========================================
+ Hits 16499 16751 +252
- Misses 3864 3870 +6
- Partials 0 0 —Generated by Codecov Action |
BYK
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Several model-based tests using
fast-checkintermittently timeout with the default 5000ms limit:test/lib/db/model-based.test.ts— "alias lookup is case-insensitive"test/lib/db/pagination.model-based.test.ts— "get on empty table returns undefined", "composite key: different command keys are independent"test/lib/db/dsn-cache.model-based.test.ts— "random sequences of cache operations maintain consistency"Root Cause
bunfig.toml'stimeout = 30000under[test]is not a supported config key in Bun 1.3.x — it's silently ignored. All tests were running with Bun's default 5000ms per-test timeout.Model-based tests routinely take 5–17s per test due to 50 fast-check iterations, each creating a new SQLite DB (12 tables + migrations) with
size: "+1"generating 10–30+ command sequences.Changes
bunfig.toml— Remove non-functionaltimeout = 30000package.json— Add--timeout 15000totest:unit,test:isolated, andtest:e2escriptsAGENTS.md— Document the bunfig.toml timeout gotcha as a lore entryFixes #366