Conversation
…page tables The ASCII art tables in Terminal and FeatureTerminal components were getting unwanted CSS borders from global `pre` rules, and column headers were misaligned due to Astro's smartypants converting quotes/ellipsis and JetBrains Mono rendering box-drawing characters at inconsistent widths. - Exclude `.table-box` from global pre border rules - Add dedicated pre.table-box styles that strip all chrome - Force system monospace font with consistent glyph metrics on all table-box children to guarantee column alignment - Disable markdown smartypants to prevent character substitution inside pre blocks Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
🤖 This preview updates automatically when you update the PR. |
|
Codecov Results 📊✅ 104 passed | Total: 104 | Pass Rate: 100% | Execution Time: 0ms 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 4092 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 80.78% 80.78% —%
==========================================
Files 131 131 —
Lines 21291 21291 —
Branches 0 0 —
==========================================
+ Hits 17199 17199 —
- Misses 4092 4092 —
- Partials 0 0 —Generated by Codecov Action |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| text-decoration: none !important; | ||
| text-transform: none !important; | ||
| -webkit-text-size-adjust: none !important; | ||
| } |
There was a problem hiding this comment.
Wildcard !important overrides alias-hl bold and underline styling
Medium Severity
The pre.table-box * rule sets font-weight: 400 !important and text-decoration: none !important, which overrides the .alias-hl class styling (font-weight: 700 and text-decoration: underline) defined in both Terminal.astro and FeatureTerminal.astro. Since .alias-hl spans are children of pre.table-box, the wildcard selector matches them and the !important wins, silently removing the bold+underline highlighting on alias characters in the tables.
Additional Locations (1)
| pre.table-box, | ||
| pre.table-box * { | ||
| font-family: ui-monospace, 'Cascadia Code', 'Source Code Pro', Menlo, Consolas, 'DejaVu Sans Mono', monospace !important; | ||
| font-size: inherit !important; |
There was a problem hiding this comment.
Wildcard !important overrides intentional table font-size 0.7rem
Medium Severity
The pre.table-box and pre.table-box * rules set font-size: inherit !important, overriding the intentional font-size: 0.7rem defined for .table-box and .header-text in both Terminal.astro and FeatureTerminal.astro. The table text will inherit the parent's larger font-size (e.g., 0.8rem from .terminal-body), making the ASCII art tables bigger than designed, which could itself break the column alignment this PR aims to fix.
1 participant
Summary
Fixes the ASCII art tables on the landing page that had double borders (CSS border on top of box-drawing characters) and misaligned column headers. The root cause was twofold: global
prestyling rules adding unwanted borders/padding, and Astro's smartypants converting'→'and...→…inside<pre>blocks which broke monospace alignment.Changes
.table-boxfrom two globalpreborder rules incustom.csspre.table-boxreset that strips background, border, padding, and marginmarkdown.smartypantsinastro.config.mjsto prevent character substitution that breaks monospace column widthsTest plan
/) — both Terminal and FeatureTerminal tables should have no CSS border, only ASCII box-drawing borders/getting-started/) still have their border styling