feat(init): enforce canonical feature display order#388
Merged
Conversation
…rompt Sort features into a fixed display order (Errors → Replay → Tracing → Logs → Metrics → Profiling → Source Maps) on the CLI side, so the prompt is consistent regardless of server ordering. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Init
Other
Bug Fixes 🐛Init
Other
Internal Changes 🔧Init
Other
🤖 This preview updates automatically when you update the PR. |
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Address PR #388 review comments: sync test expectations with updated feature copy, and use Number.MAX_SAFE_INTEGER instead of Infinity to avoid NaN when comparing two unknown features. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Codecov Results 📊✅ 104 passed | Total: 104 | Pass Rate: 100% | Execution Time: 0ms 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 899 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 95.49% 95.49% —%
==========================================
Files 142 142 —
Lines 19935 19954 +19
Branches 0 0 —
==========================================
+ Hits 19036 19055 +19
- Misses 899 899 —
- Partials 0 0 —Generated by Codecov Action |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sorts the feature multi-select prompt into a fixed display order instead of relying on whatever the server sends. Also tweaks a couple of feature labels/hints for clarity.
Display order: Errors → Replay → Tracing → Logs → Metrics → Profiling → Source Maps
Changes
FEATURE_DISPLAY_ORDERconstant andsortFeatures()helper inclack-utils.tshandleMultiSelect()before rendering the promptTest plan
bun run typecheckpassesbun testpasses (no regressions)bun run devagainst staging API, confirm multi-select shows features in the expected order