fix: accept nullable user fields in OAuth token response#470
Merged
Conversation
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Bug Fixes 🐛
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
Contributor
Codecov Results 📊✅ 126 passed | Total: 126 | Pass Rate: 100% | Execution Time: 0ms 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 1034 uncovered lines. Files with missing lines (2)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 95.35% 95.70% +0.35%
==========================================
Files 177 177 —
Lines 24086 24065 -21
Branches 0 0 —
==========================================
+ Hits 22965 23031 +66
- Misses 1121 1034 -87
- Partials 0 0 —Generated by Codecov Action |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
BYK
force-pushed
the
fix/oauth-nullable-user-name
branch
2 times, most recently
from
f2b2554 to
4061009
Compare
BYK
commented
Mar 19, 2026
BYK
commented
Mar 19, 2026
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
The Sentry API can return `null` for `user.name` in the OAuth token response. The Zod schema had `name: z.string()` which rejected null, causing `safeParse()` to fail and login to throw 'Unexpected response from token endpoint'. - Make `name` and `email` nullable in `TokenResponseSchema` - Make `name` nullish in `SentryUserSchema` for consistency - Convert null → undefined at the UserInfo/LoginResult boundary - Add focused schema tests for nullable user fields Closes #468
BYK
force-pushed
the
fix/oauth-nullable-user-name
branch
from
4061009 to
177e049
Compare
5 tasks
|
Thanks for the amazing fast fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Sentry API can return
nullforuser.namein the OAuth token response. The Zod schema hadname: z.string()which rejected null, causingsafeParse()to fail and login to throw 'Unexpected response from token endpoint'.Changes
nameandemailnullable inTokenResponseSchema(root cause)namenullish inSentryUserSchemafor consistencyinteractive-login.ts,auth/login.ts, andauth/whoami.tsCloses #468