Skip to content

fix: lowercase project slug in URL-parsed issue short IDs (CLI-C8 follow-up)#506

Merged
BYK merged 1 commit intomainfrom
fix/cli-c8-url-lowercase
Mar 20, 2026
Merged

fix: lowercase project slug in URL-parsed issue short IDs (CLI-C8 follow-up)#506
BYK merged 1 commit intomainfrom
fix/cli-c8-url-lowercase

Conversation

@BYK
Copy link
Member

@BYK BYK commented Mar 20, 2026

Follow-up to PR #496

Addresses unresolved Bugbot review comment (High severity) that was missed before merging #496.

Problem

issueArgFromUrl returned the project slug without .toLowerCase() when parsing Sentry issue URLs like:

https://sentry.io/organizations/my-org/issues/CLI-G/

This produced project: "CLI" (uppercase) which fails API lookups since Sentry slugs are always lowercase. The other three parsing paths (parseWithDash, parseAfterSlash, parseMultiSlashIssueArg) were already fixed in PR #496.

Fix

Added .toLowerCase() to the project slug in issueArgFromUrl and updated two test expectations to match.

…low-up)

Address unresolved Bugbot review from PR #496: issueArgFromUrl returned
the project slug without .toLowerCase() when parsing Sentry issue URLs
like https://sentry.io/organizations/org/issues/CLI-G/. This meant the
URL parsing path still produced uppercase project slugs ('CLI') that
would fail API lookups, while the other three parsing paths (parseWithDash,
parseAfterSlash, parseMultiSlashIssueArg) were already fixed.
@github-actions
Copy link
Contributor

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

  • (telemetry) Track TTY vs non-TTY invocations via metric by betegon in #482
  • Dynamic cache-backed shell completions with fuzzy matching by BYK in #465

Bug Fixes 🐛

  • (help) Hide ASCII banner when stdout is not a TTY by betegon in #501
  • (json) Flatten view command JSON output for --fields filtering by BYK in #495
  • (project) Fallback to org listing when bare slug matches an organization by betegon in #475
  • Lowercase project slug in URL-parsed issue short IDs (CLI-C8 follow-up) by BYK in #506
  • Use fuzzyMatch for similar project suggestions and add tests (CLI-C0) by BYK in #504
  • Use resolved org in numeric issue ID 404 hint (CLI-BT) by BYK in #502
  • Include API endpoint in error messages for better diagnostics (CLI-BS) by BYK in #500
  • Enrich 403 on org listing with token scope guidance (CLI-89) by BYK in #498
  • Add 400 suggestions to org-all issue list path (CLI-BY) by BYK in #497
  • Lowercase project slug in issue arg parsing (CLI-C8) by BYK in #496
  • Enrich short ID 404 with org context and suggestions (CLI-A1) by BYK in #494
  • Suggest similar projects when project not found in org (CLI-C0) by BYK in #493
  • Event 404 hint should suggest different project, not repeat failing command by BYK in #492
  • Enrich event 404 errors with retention and format suggestions (CLI-6F) by BYK in #491
  • Add actionable suggestions for 400 Bad Request on issue list (CLI-BM, CLI-7B) by BYK in #489
  • Detect issue short IDs passed to issue list (CLI-C3) by BYK in #488
  • Add Glob.match() polyfill + improve auto-detect diagnostics (CLI-7T) by BYK in #487
  • Add org-slug pre-check to dispatchOrgScopedList (CLI-9A) by BYK in #485

Internal Changes 🔧

  • (issue) Skip getProject round-trip in project-search resolution by betegon in #473
  • (resolve) Carry project data through resolution to eliminate redundant getProject calls by BYK in #486
  • (telemetry) Convert is_tty metric to span tag by betegon in #499
  • HTTP latency optimizations — diagnostics, cache warming, concurrency limits by BYK in #490
  • Switch from @sentry/bun to @sentry/node-core/light (~170ms startup savings) by BYK in #474
  • Regenerate skill files by github-actions[bot] in b7b240ec

🤖 This preview updates automatically when you update the PR.

@github-actions
Copy link
Contributor

Codecov Results 📊

126 passed | Total: 126 | Pass Rate: 100% | Execution Time: 0ms

📊 Comparison with Base Branch

Metric Change
Total Tests
Passed Tests
Failed Tests
Skipped Tests

✨ No test changes detected

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 1057 uncovered lines.
✅ Project coverage is 95.72%. Comparing base (base) to head (head).

Files with missing lines (1)
File Patch % Lines
arg-parsing.ts 94.65% ⚠️ 19 Missing
Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    95.72%    95.72%        —%
==========================================
  Files          180       180         —
  Lines        24711     24716        +5
  Branches         0         0         —
==========================================
+ Hits         23654     23659        +5
- Misses        1057      1057         —
- Partials         0         0         —

Generated by Codecov Action

@BYK BYK merged commit a266720 into main Mar 20, 2026
22 checks passed
@BYK BYK deleted the fix/cli-c8-url-lowercase branch March 20, 2026 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant