fix: lowercase project slug in URL-parsed issue short IDs (CLI-C8 follow-up)#506
Merged
fix: lowercase project slug in URL-parsed issue short IDs (CLI-C8 follow-up)#506
Conversation
…low-up) Address unresolved Bugbot review from PR #496: issueArgFromUrl returned the project slug without .toLowerCase() when parsing Sentry issue URLs like https://sentry.io/organizations/org/issues/CLI-G/. This meant the URL parsing path still produced uppercase project slugs ('CLI') that would fail API lookups, while the other three parsing paths (parseWithDash, parseAfterSlash, parseMultiSlashIssueArg) were already fixed.
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
Contributor
Codecov Results 📊✅ 126 passed | Total: 126 | Pass Rate: 100% | Execution Time: 0ms 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 1057 uncovered lines. Files with missing lines (1)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 95.72% 95.72% —%
==========================================
Files 180 180 —
Lines 24711 24716 +5
Branches 0 0 —
==========================================
+ Hits 23654 23659 +5
- Misses 1057 1057 —
- Partials 0 0 —Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to PR #496
Addresses unresolved Bugbot review comment (High severity) that was missed before merging #496.
Problem
issueArgFromUrlreturned the project slug without.toLowerCase()when parsing Sentry issue URLs like:This produced
project: "CLI"(uppercase) which fails API lookups since Sentry slugs are always lowercase. The other three parsing paths (parseWithDash,parseAfterSlash,parseMultiSlashIssueArg) were already fixed in PR #496.Fix
Added
.toLowerCase()to the project slug inissueArgFromUrland updated two test expectations to match.