feat(telemetry): include user email in Sentry telemetry context#513
Merged
Conversation
Contributor
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Telemetry
Other
Bug Fixes 🐛
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
Add user email to the Sentry.setUser() call in initTelemetryContext() alongside the existing user ID. The email is already stored in the local SQLite DB from login/whoami flows — this change simply passes it through. When email is undefined (minimal user info), Sentry ignores the field.
5a0ce3b to
700bb91
Compare
Contributor
Codecov Results 📊✅ 126 passed | Total: 126 | Pass Rate: 100% | Execution Time: 0ms 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ❌ Patch coverage is 0.00%. Project has 1047 uncovered lines. Files with missing lines (1)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 95.56% 95.77% +0.21%
==========================================
Files 180 180 —
Lines 24776 24767 -9
Branches 0 0 —
==========================================
+ Hits 23677 23720 +43
- Misses 1099 1047 -52
- Partials 0 0 —Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add user email to the
Sentry.setUser()call ininitTelemetryContext()alongside the existing user ID. The email is already stored in the local SQLite DB from login/whoami flows — this change simply passes it through.When
emailisundefined(minimal user info with only userId), Sentry ignores the field.Changes
src/lib/telemetry.ts: Passuser.emailtoSentry.setUser()alongsideuser.userId