fix(dashboard): show actionable error messages instead of raw API errors#592
Merged
fix(dashboard): show actionable error messages instead of raw API errors#592
Conversation
Add a shared `enrichDashboardError()` helper in resolve.ts that converts raw 404/403/400 ApiError responses into ResolutionError instances with actionable suggestions (org not found, dashboard not found, access denied, invalid widget config). Wire the helper into all dashboard API calls across list, view, create, and widget add/edit/delete commands using `.catch()`. Closes #448
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
Contributor
Codecov Results 📊✅ 126 passed | Total: 126 | Pass Rate: 100% | Execution Time: 0ms 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 1265 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 95.66% 95.67% +0.01%
==========================================
Files 202 202 —
Lines 29143 29233 +90
Branches 0 0 —
==========================================
+ Hits 27878 27968 +90
- Misses 1265 1265 —
- Partials 0 0 —Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
enrichDashboardError()helper that converts raw 404/403/400 API errors intoResolutionErrorinstances with actionable suggestionslist,view,create, andwidget add/edit/deletecommandsBefore:
After:
Closes #448