fix(init): run commands without shell to eliminate injection surface#665
Merged
fix(init): run commands without shell to eliminate injection surface#665
Conversation
Replace spawn({ shell: true }) with direct executable invocation by
splitting the command string into [executable, ...args]. This eliminates
shell injection as an attack vector entirely — metacharacters become
harmless literal arguments. The existing validateCommand() blocklist is
retained as defense-in-depth.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛Init
Other
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
Contributor
Codecov Results 📊✅ 134 passed | Total: 134 | Pass Rate: 100% | Execution Time: 0ms 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 1428 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 95.53% 95.54% +0.01%
==========================================
Files 220 220 —
Lines 31986 31986 —
Branches 0 0 —
==========================================
+ Hits 30555 30558 +3
- Misses 1431 1428 -3
- Partials 0 0 —Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spawn({ shell: true })with direct executable invocation — command strings are split into[executable, ...args]and passed tospawnwithout a shellvalidateCommand()blocklist (metachar, env var, blocked executable checks) is retained as defense-in-depthAddresses this review comment.
Test plan
/bin/echoand/usr/bin/falseinstead of shell builtinsrun-commandstests pass (stdout capture, error handling, blocked commands, dry-run, batch validation)tsc --noEmitpassesbiome checkpasses🤖 Generated with Claude Code