fix(dashboard): render tracemetrics widgets in dashboard view#695
Merged
Conversation
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
Contributor
Codecov Results 📊✅ 134 passed | Total: 134 | Pass Rate: 100% | Execution Time: 0ms 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 1481 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 95.43% 95.45% +0.02%
==========================================
Files 224 224 —
Lines 32532 32534 +2
Branches 0 0 —
==========================================
+ Hits 31046 31053 +7
- Misses 1486 1481 -5
- Partials 0 0 —Generated by Codecov Action |
tracemetrics was missing from WIDGET_TYPE_TO_DATASET, causing
mapWidgetTypeToDataset("tracemetrics") to return null and all
tracemetrics widgets to be classified as "unsupported" placeholders.
Add the mapping tracemetrics → "metricsEnhanced" so the existing
timeseries/big_number rendering paths handle these widgets correctly.
BYK
force-pushed
the
fix/692-tracemetrics-widget-rendering
branch
from
8a838f0 to
74b09c7
Compare
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tracemetrics → "metricsEnhanced"toWIDGET_TYPE_TO_DATASETso tracemetrics widgets are no longer classified as "unsupported" placeholdersCloses #692