feat(docs): deploy main branch preview alongside PR previews#707
Merged
Conversation
Contributor
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Docs
Other
Bug Fixes 🐛Dashboard
Other
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
Extend the docs-preview workflow to also trigger on pushes to main, deploying a continuously-updated preview at _preview/pr-main/ on gh-pages. Rename the umbrella directory from pr-preview to _preview. - Add push:main trigger with same path filters as pull_request - Use conditional action inputs (deploy+no comment for main, auto for PRs) - Scope concurrency per-ref with cancel-in-progress - Update astro landing page regex for the new _preview path
BYK
force-pushed
the
feat/main-docs-preview
branch
from
342c683 to
cca6856
Compare
Contributor
|
Contributor
Codecov Results 📊✅ 134 passed | Total: 134 | Pass Rate: 100% | Execution Time: 0ms 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 1570 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 95.30% 95.30% —%
==========================================
Files 229 229 —
Lines 33377 33378 +1
Branches 0 0 —
==========================================
+ Hits 31808 31808 —
- Misses 1569 1570 +1
- Partials 0 0 —Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
main, deploying a continuously-updated preview to_preview/pr-main/ongh-pagespr-previewto_previewdocs-preview-${{ github.ref }}) withcancel-in-progress: trueDetails
Production deploys via Craft remain unchanged. This adds a
mainbranch preview so merged docs changes are immediately viewable atcli.sentry.dev/_preview/pr-main/without waiting for a release.The workflow reuses
rossjrw/pr-preview-actionfor both cases with conditional inputs:action: deploy,pr-number: main,comment: falseaction: auto(unchanged behavior)The astro config's landing page regex is updated to match the new
_previewpath and themainpreview.Old
pr-preview/directory ongh-pagesis left as-is (harmless, will be cleaned up by future Craft releases).