fix(init): remove JSON minification that breaks edit-based codemods#719
Merged
fix(init): remove JSON minification that breaks edit-based codemods#719
Conversation
readSingleFile and preReadCommonFiles minified JSON files before sending them to the server. The server's codemod-planner saw minified content and generated edits based on it, but applyEdits reads the actual file from disk (pretty-printed). The oldString from minified JSON never matched the pretty-printed file, causing all package.json edits to fail. All reference projects (opencode, gemini-cli, cline) read files raw without transformation — the model sees exactly what's on disk. Made-with: Cursor
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Bug Fixes 🐛
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
Contributor
|
Contributor
Codecov Results 📊✅ 134 passed | Total: 134 | Pass Rate: 100% | Execution Time: 0ms 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 1592 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
- Coverage 95.32% 95.31% -0.01%
==========================================
Files 232 232 —
Lines 33951 33949 -2
Branches 0 0 —
==========================================
+ Hits 32361 32357 -4
- Misses 1590 1592 +2
- Partials 0 0 —Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes JSON minification (
JSON.stringify(JSON.parse())) fromreadSingleFileandpreReadCommonFiles. This was causing allpackage.jsonedit-based codemods to fail.Root cause
The server's codemod-planner agent saw minified JSON (all whitespace stripped) and generated
oldString/newStringedits based on it. ButapplyEditsreads the actual file from disk (pretty-printed with indentation). The fuzzy replacer chain can't bridge minified vs pretty-printed JSON — it's structurally too different.Evidence
All three reference projects (opencode, gemini-cli, cline) read files raw without any content transformation. The model always sees exactly what's on disk. Our minification was an outlier that broke when we switched from full-content replacement to edit-based codemods.
Fixes failures on node-express and remix test projects:
Test plan
Made with Cursor