fix(init): treat no-op edits as passthrough instead of throwing#731
Merged
fix(init): treat no-op edits as passthrough instead of throwing#731
Conversation
When the AI agent generates an edit where oldString equals newString, return the content unchanged instead of throwing. The agent sometimes produces redundant no-op edits (e.g., package.json already has the right content), and crashing on those triggered 4 retries followed by "Codemod recovery produced no modifications." Made-with: Cursor
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛Init
Upgrade
Other
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
Contributor
|
Contributor
Codecov Results 📊✅ 134 passed | Total: 134 | Pass Rate: 100% | Execution Time: 0ms 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 1652 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 95.19% 95.19% —%
==========================================
Files 234 234 —
Lines 34349 34347 -2
Branches 0 0 —
==========================================
+ Hits 32697 32695 -2
- Misses 1652 1652 —
- Partials 0 0 —Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the AI agent generates an edit where
oldString === newString, return the content unchanged instead of throwing. The agent sometimes produces redundant no-op edits (e.g., package.json already has the right content), and crashing on those triggered 4 retries followed by "Codemod recovery produced no modifications."This is a deliberate deviation from opencode's
replace()which throws on identical strings — their context is interactive editing where it's a user mistake. In our agent context, no-op edits are benign.Test plan
Made with Cursor