fix(init): force process exit after wizard completes#782
Merged
Conversation
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
Contributor
|
e8dc024 to
5152bf1
Compare
`sentry init` is a terminal command, but Bun's global fetch dispatcher (used by MastraClient) holds keep-alive sockets open after requests return, leaving the libuv loop alive and the shell hung after the wizard finishes. Manifests in `curl | bash` SENTRY_INIT=1 flows where the user has to press Ctrl+C to recover the prompt. Fixes #780. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
5152bf1 to
8c6722a
Compare
Contributor
Codecov Results 📊✅ 138 passed | Total: 138 | Pass Rate: 100% | Execution Time: 0ms 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 1705 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 95.50% 95.53% +0.03%
==========================================
Files 262 262 —
Lines 38170 38173 +3
Branches 0 0 —
==========================================
+ Hits 36454 36468 +14
- Misses 1716 1705 -11
- Partials 0 0 —Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sentry inithangs after the wizard finishes, requiring Ctrl+C (or, with the partial fix from this branch's earlier iteration, one Enter) to recover the shell promptMastraClient) holds keep-alive sockets open after requests return, keeping the libuv loop alive past the wizard. There's no clean programmatic close for it.Fixes #780.
Test plan
🤖 Generated with Claude Code