refactor(issue): extract shared parameters for issue commands#79
Merged
Conversation
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Issue
Other
Bug Fixes 🐛Issue
Other
Documentation 📚
Internal Changes 🔧
Other
🤖 This preview updates automatically when you update the PR. |
Contributor
Codecov Results 📊✅ Patch coverage is 96.15%. Project has 1663 uncovered lines. Files with missing lines (22)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 64.65% 64.83% +0.18%
==========================================
Files 39 39 —
Lines 4702 4728 +26
Branches 0 0 —
==========================================
+ Hits 3040 3065 +25
- Misses 1662 1663 +1
- Partials 0 0 —Generated by Codecov Action |
967aa1a to
077d242
Compare
Add shared parameter definitions (IssueIdFlags, issueIdFlags, issueIdPositional) that all issue commands (except list) can use. This ensures consistent --org and --project flag handling and issue ID acceptance across view, explain, and plan commands. - Add IssueIdFlags type and issueIdFlags definition in utils.ts - Add issueIdPositional for shared positional parameter - Add buildCommandHint() helper for error messages - Refactor view, explain, plan commands to use shared definitions
077d242 to
e78ee9a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extracts shared parameter definitions for issue commands so that `view`, `explain`, `plan` (and future commands) automatically get consistent `--org` and `--project` flags and issue ID support.
Changes
Benefits