chore(deps): drop Node 20 support, pin CI Node 24 for docs build#817
Merged
chore(deps): drop Node 20 support, pin CI Node 24 for docs build#817
Conversation
Node 20 reached end of life in April 2026, and the prior workaround for Astro 6's `engines.node >= 22.12` requirement was putting `bun --bun astro` into docs/package.json scripts just to route around the GHA runner's Node 20. - Tighten repo engines.node from `>=22` to `>=22.12` to reflect the real minimum (Astro 6) and drop support for EOL'd Node 20. - Add `actions/setup-node@v6` (node-version 24) to the `Build Docs` and `preview` jobs so the docs build has a Node matching Astro's engine requirement, removing the `--bun` workaround. - Revert docs/package.json scripts to plain `astro dev/build/preview` now that every runtime context has a compatible Node. The Build npm Package job's `"22", "24"` matrix stays; Node 22 is still LTS (EOL April 2027) and comfortably above the 22.12 minimum.
Contributor
|
Contributor
Codecov Results 📊✅ 138 passed | Total: 138 | Pass Rate: 100% | Execution Time: 0ms 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 1954 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 95.18% 95.19% +0.01%
==========================================
Files 282 282 —
Lines 40664 40665 +1
Branches 0 0 —
==========================================
+ Hits 38705 38711 +6
- Misses 1959 1954 -5
- Partials 0 0 —Generated by Codecov Action |
Outside-review follow-ups on #817: - script/bundle.ts: the generated dist/bin.cjs wrapper checked only `parseInt(process.versions.node) < 22`, which would let Node 22.0 – 22.11.x past the runtime guard even though package.json declares `engines.node: ">=22.12"`. Tighten the inline check to major < 22 || (major === 22 && minor < 12) and update the error message to match. - sentry-release.yml: drop the "(ubuntu-latest ships 20)" parenthetical on the setup-node step — now stale after dropping Node 20 support. The step itself is unchanged (already pins node 22, which satisfies >=22.12 via latest 22.x LTS). Verified: - `SENTRY_CLIENT_ID=x bun run bundle && node dist/bin.cjs --help` runs on Node 24. - Boundary check: 22.11.5 errors, 22.12.0 passes, 24.13.0 passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Node 20 reached EOL in April 2026. This PR drops it from the supported set and cleans up the Astro 6 engine-check workaround that #816 left in place.
Changes
package.json— tighten enginesengines.node:>=22→>=22.12(matches Astro 6 and reflects Node 20 EOL).docs/package.json— revertbun --bun astroworkaroundastro dev / build / preview.bun --bunonly to route around the GHA runner's Node 20 shipping below Astro 6'sengines.node: ">=22.12". With a real Node pin in CI (below) and Node 24 locally, there's no reason to keep it.Workflows — pin Node 24 for docs jobs
ci.ymlBuild Docsanddocs-preview.ymlpreviewnow both runactions/setup-node@v6withnode-version: "24"before the docs build.# works on Node < 22.12 …comments.Unchanged
Build npm PackageCI matrix stays at["22", "24"]. Node 22 is still LTS (EOL April 2027) and above the new 22.12 minimum.node-version: 22(release workflows) are fine as-is.Verification