build(deps): bump @sentry/node-core to 10.50.0#834
Merged
Conversation
Regenerate both patches against 10.50.0 bundles via `bun patch`. Keep `spanStreamingIntegration` export in @sentry/core because node-core/light/sdk.js in 10.50.0 imports and calls it at runtime when traceLifecycle === 'stream'. Stripping it (as the old patch did) would throw `SyntaxError: Export named 'spanStreamingIntegration' not found` on the first `Sentry.init()` load. Also strip newly-added exports we do not use: - `withStreamedSpan` (from node-core/light + core) - `instrumentLangChainEmbeddings` (from core) Transitive bumps: @sentry/core, @sentry/opentelemetry → 10.50.0; @opentelemetry/context-async-hooks dropped from the dep tree. Verified: typecheck, lint, 5915 tests pass, `bun run build` and `bun run bundle` both succeed, completion fast-path still ~200ms.
Contributor
Codecov Results 📊✅ 138 passed | Total: 138 | Pass Rate: 100% | Execution Time: 0ms 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 1938 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 95.30% 95.30% —%
==========================================
Files 283 283 —
Lines 41243 41244 +1
Branches 0 0 —
==========================================
+ Hits 39303 39306 +3
- Misses 1940 1938 -2
- Partials 0 0 —Generated by Codecov Action |
- Drop stray `.bun-tag-<hash>` hunk from core patch (bun auto-creates
its own tag marker on install; the one baked into the patch was
redundant and shipped an empty file in every install).
- Fix AGENTS.md lore entry: `withStreamedSpan` is NOT imported at
runtime by `@sentry/node-core/build/{cjs,esm}/light/*` — only
`spanStreamingIntegration` is. Correct the constraint so future
bumpers don't preserve `withStreamedSpan` unnecessarily.
- Document the `.bun-tag` artifact workaround in the same lore entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps the sentry-javascript SDK from 10.47.0 → 10.50.0.
Nothing in the 10.48/10.49/10.50 changelog affects the CLI — the minors added Effect v4, Hono/Bun, Replay hooks, AI integrations, ViewHierarchy, Runtime Metrics, etc. None are imported here. Relevant-but-benign fixes:
fix(node-core): Pass rejection reason instead of Promise as originalException(10.50)fix(core): Only attach flags context to error events(10.48)@opentelemetry/api@1.9.0.What changed
package.json: exact-pin bumped10.47.0 → 10.50.0;patchedDependencieskeys + paths updated to 10.50.0.patches/@sentry%2Fnode-core@10.50.0.patch(77 lines, regenerated fresh viabun patch).patches/@sentry%2Fcore@10.50.0.patch(253 lines, regenerated fresh viabun patch).bun.lock:@sentry/core,@sentry/node-core,@sentry/opentelemetryall to 10.50.0;@opentelemetry/context-async-hooksdropped from the transitive tree.AGENTS.md: new lore entry documenting the patch-regeneration workflow and the gotcha below.Patches continue to strip unused integrations (
captureConsoleIntegration,dedupeIntegration,extraErrorDataIntegration,featureFlagsIntegration,instrumentSupabaseClient,profiler,rewriteFramesIntegration,supabaseIntegration,trpcMiddleware,wrapMcpServerWithSentry,zodErrorsIntegration, AI instrumentation for OpenAI/Anthropic/GoogleGenAI/LangChain/LangGraph/Vercel-AI, feature-flag internals, module metadata, idle-span, etc.) from the@sentry/node-core/lightand@sentry/corebundles so the light startup stays fast.Also strips newly-added exports we don't use:
withStreamedSpan(node-core/light + core)instrumentLangChainEmbeddings(core)Gotcha:
spanStreamingIntegrationmust stay exported from@sentry/core10.50.0 introduced runtime usage of
spanStreamingIntegrationinside@sentry/node-core/build/{cjs,esm}/light/sdk.js:An early version of this patch stripped that export from
@sentry/core, which caused:on the first
Sentry.init()load. The final patch keepsspanStreamingIntegrationexported from@sentry/core, but still strips it from thenode-core/lightre-export surface since we never import it directly.Verification
Post-review cleanup (2nd commit)
Subagent review surfaced two nits after initial CI green:
.bun-tag-<hash>hunk at the top that would create an empty marker file in every install. Removed.withStreamedSpanalongsidespanStreamingIntegrationas a runtime dependency ofnode-core/light/sdk.js. VerifiedwithStreamedSpanis NOT used there — stripping it is safe. Corrected the entry and documented the.bun-tagworkaround for future regenerators.