fix(span-list): query all projects in trace mode for cross-project traces#878
Merged
fix(span-list): query all projects in trace mode for cross-project traces#878
Conversation
…aces
listSpans() always scoped queries to a single project via project:{slug}.
For traces spanning multiple projects, the auto-detected project might
not participate in the trace, returning empty results.
- Add allProjects option to listSpans that sends project=-1
- Enable allProjects in trace mode since trace:{id} already scopes results
- Project mode unchanged (single-project queries still correct)
Closes #735
Contributor
|
Contributor
Codecov Results 📊✅ 6258 passed | Total: 6258 | Pass Rate: 100% | Execution Time: 0ms 📊 Comparison with Base Branch
All tests are passing successfully. ❌ Patch coverage is 64.71%. Project has 13024 uncovered lines. Files with missing lines (1)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
- Coverage 76.00% 75.95% -0.05%
==========================================
Files 293 293 —
Lines 54108 54150 +42
Branches 0 0 —
==========================================
+ Hits 41121 41126 +5
- Misses 12987 13024 +37
- Partials 0 0 —Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sentry span list <trace-id>on traces spanning multiple projectsallProjectsoption tolistSpans()that sendsproject=-1to the API, querying across all projectsallProjects: truein trace mode — thetrace:{id}query already scopes results to the correct traceRoot Cause
listSpans()always prependedproject:{slug}to the query. For cross-project traces, the auto-detected project might not participate in the trace, causing the API to return zero spans.Test Plan
allProjects: trueis passed in trace mode and NOT in project modeCloses #735