feat: sourcemap upload parity flags and issue archive command #883
+827
−38
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,126 @@ | ||
| /** | ||
| * sentry issue archive (aliased: ignore) | ||
| * | ||
| * Archive (ignore) an issue, suppressing alerts until an optional | ||
| * condition is met. This maps to the "ignored" status in the Sentry API. | ||
| */ | ||
|
|
||
| import type { SentryContext } from "../../context.js"; | ||
| import { | ||
| type IgnoreStatusDetails, | ||
| updateIssueStatus, | ||
| } from "../../lib/api-client.js"; | ||
| import { buildCommand } from "../../lib/command.js"; | ||
| import { formatIssueDetails, muted } from "../../lib/formatters/index.js"; | ||
| import { CommandOutput } from "../../lib/formatters/output.js"; | ||
| import { logger } from "../../lib/logger.js"; | ||
| import type { SentryIssue } from "../../types/index.js"; | ||
| import { issueIdPositional, resolveIssue } from "./utils.js"; | ||
|
|
||
| const log = logger.withTag("issue.archive"); | ||
|
|
||
| const COMMAND = "archive"; | ||
|
|
||
| type ArchiveFlags = { | ||
| readonly json: boolean; | ||
| readonly fields?: string[]; | ||
| readonly duration?: number; | ||
| readonly count?: number; | ||
| readonly window?: number; | ||
| readonly users?: number; | ||
| readonly "user-window"?: number; | ||
| }; | ||
|
|
||
| function formatArchived(issue: SentryIssue): string { | ||
| return `${muted("Archived")}\n\n${formatIssueDetails(issue)}`; | ||
| } | ||
|
|
||
| export const archiveCommand = buildCommand({ | ||
| docs: { | ||
| brief: "Archive (ignore) an issue", | ||
| fullDescription: | ||
| "Archive an issue, suppressing alerts until an optional condition is met.\n" + | ||
| "Without any duration/count flags, the issue is archived indefinitely.\n\n" + | ||
| "Examples:\n" + | ||
| " sentry issue archive CLI-12Z\n" + | ||
| " sentry issue archive CLI-12Z --duration 60\n" + | ||
| " sentry issue archive CLI-12Z --count 100 --window 60\n" + | ||
| " sentry issue archive CLI-12Z --users 10", | ||
| }, | ||
| output: { | ||
| human: formatArchived, | ||
| }, | ||
| parameters: { | ||
| positional: issueIdPositional, | ||
| flags: { | ||
| duration: { | ||
| kind: "parsed", | ||
| parse: Number, | ||
| brief: "Ignore for this many minutes", | ||
| optional: true, | ||
| }, | ||
| count: { | ||
| kind: "parsed", | ||
| parse: Number, | ||
| brief: "Ignore until this many more events occur", | ||
| optional: true, | ||
| }, | ||
| window: { | ||
| kind: "parsed", | ||
| parse: Number, | ||
| brief: | ||
| "Time window in minutes for --count (events must occur within this window)", | ||
| optional: true, | ||
| }, | ||
| users: { | ||
| kind: "parsed", | ||
| parse: Number, | ||
| brief: "Ignore until this many more users are affected", | ||
| optional: true, | ||
| }, | ||
| "user-window": { | ||
| kind: "parsed", | ||
| parse: Number, | ||
| brief: | ||
| "Time window in minutes for --users (users must be affected within this window)", | ||
| optional: true, | ||
| }, | ||
| }, | ||
| }, | ||
| async *func(this: SentryContext, flags: ArchiveFlags, issueArg: string) { | ||
| const { cwd } = this; | ||
|
|
||
| const { org, issue } = await resolveIssue({ | ||
| issueArg, | ||
| cwd, | ||
| command: COMMAND, | ||
| }); | ||
|
|
||
| const statusDetails: IgnoreStatusDetails = {}; | ||
| if (flags.duration !== undefined) { | ||
| statusDetails.ignoreDuration = flags.duration; | ||
| } | ||
| if (flags.count !== undefined) { | ||
| statusDetails.ignoreCount = flags.count; | ||
| } | ||
| if (flags.window !== undefined) { | ||
| statusDetails.ignoreWindow = flags.window; | ||
| } | ||
| if (flags.users !== undefined) { | ||
| statusDetails.ignoreUserCount = flags.users; | ||
| } | ||
| if (flags["user-window"] !== undefined) { | ||
| statusDetails.ignoreUserWindow = flags["user-window"]; | ||
| } | ||
|
|
||
| const hasDetails = Object.keys(statusDetails).length > 0; | ||
|
|
||
| const updated = await updateIssueStatus(issue.id, "ignored", { | ||
| ...(hasDetails ? { statusDetails } : {}), | ||
| orgSlug: org, | ||
| }); | ||
|
|
||
| log.debug(`Archived ${updated.shortId}`); | ||
| yield new CommandOutput<SentryIssue>(updated); | ||
| }, | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inject command drops
--ignore-filepatterns during injectionHigh Severity
The inject command builds an
ignoreMatcherfrom both--ignorepatterns and--ignore-file, and correctly uses it for thediscoverFilePairspre-check. But it then passes onlyignorePatterns(notignoreMatcher) toinjectDirectory. InsideinjectDirectory, the matcher is rebuilt from justignorePatterns, losing all patterns from--ignore-file. This makes--ignore-filesilently ineffective during actual injection. The upload command correctly passesignoreMatchertoinjectDirectory; the inject command needs to do the same.Additional Locations (1)
src/commands/sourcemap/upload.ts#L275-L279Reviewed by Cursor Bugbot for commit 0970403. Configure here.