feat(replay): Paginate replay segment downloads#910
Merged
Conversation
Contributor
|
Contributor
Codecov Results 📊✅ 6662 passed | Total: 6662 | Pass Rate: 100% | Execution Time: 0ms 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 85.00%. Project has 13625 uncovered lines. Files with missing lines (1)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
- Coverage 76.63% 76.48% -0.15%
==========================================
Files 303 303 —
Lines 57782 57929 +147
Branches 0 0 —
==========================================
+ Hits 44276 44304 +28
- Misses 13506 13625 +119
- Partials 0 0 —Generated by Codecov Action |
dcramer
force-pushed
the
codex/replay-segment-pagination
branch
from
987cb8d to
c1443ef
Compare
Fetch recording segments with per_page=100 and follow link cursors so long replays are fully available to replay view and later inspection commands. Drop the stale ota_updates replay list field after the live API rejected it, and add a lightweight bun run cli script for local smoke tests. Refs GH-907 Co-Authored-By: OpenAI Codex <noreply@openai.com>
dcramer
force-pushed
the
codex/replay-segment-pagination
branch
from
c1443ef to
12d6b93
Compare
BYK
changed the title
betegon
added a commit
that referenced
this pull request
May 4, 2026
Paginate replay recording segment downloads so long replays are fully available to replay view and future replay inspection commands. The API caps recording segment pages at 100 segments, so the helper now follows Link cursors and stops when the replay metadata count is satisfied. **Replay API Compatibility** Remove `ota_updates` from the replay list field set because the live replay index endpoint rejects it as invalid. The replay schemas still tolerate `ota_updates` when a payload includes it. **Local Smoke Testing** Add `bun run cli` as a lightweight runner for live CLI checks without regenerating docs and SDK first. Validated with focused replay and explore tests, typecheck, lint, and a live read-only smoke test on a 471-segment replay that fetched five segment pages: 100, 100, 100, 100, 71. Refs GH-907 --------- Co-authored-by: OpenAI Codex <noreply@openai.com> Co-authored-by: Miguel Betegón <miguelbetegongarcia@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Paginate replay recording segment downloads so long replays are fully available to replay view and future replay inspection commands. The API caps recording segment pages at 100 segments, so the helper now follows Link cursors and stops when the replay metadata count is satisfied.
Replay API Compatibility
Remove
ota_updatesfrom the replay list field set because the live replay index endpoint rejects it as invalid. The replay schemas still tolerateota_updateswhen a payload includes it.Local Smoke Testing
Add
bun run clias a lightweight runner for live CLI checks without regenerating docs and SDK first.Validated with focused replay and explore tests, typecheck, lint, and a live read-only smoke test on a 471-segment replay that fetched five segment pages: 100, 100, 100, 100, 71.
Refs GH-907