fix(archive): accept 'forever' as a valid --until value#918
Merged
Conversation
Users passing --until forever got a ValidationError. Since omitting --until already archives forever, 'forever' is a natural alias. Adds forever as a recognized keyword in parseUntilSpec (case-insensitive), maps it to archived_forever in specToApiOptions, and documents it in the flag brief and error hint text. Fixes CLI-1MD
Contributor
|
Contributor
Codecov Results 📊✅ 6681 passed | Total: 6681 | Pass Rate: 100% | Execution Time: 0ms 📊 Comparison with Base Branch
All tests are passing successfully. ❌ Patch coverage is 77.78%. Project has 13823 uncovered lines. Files with missing lines (1)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
- Coverage 76.69% 76.28% -0.41%
==========================================
Files 303 303 —
Lines 57961 58282 +321
Branches 0 0 —
==========================================
+ Hits 44453 44459 +6
- Misses 13508 13823 +315
- Partials 0 0 —Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes CLI-1MD: users passing
--until forevertosentry issue archivereceived aValidationError. Since omitting--untilalready archives forever,foreveris a natural and discoverable alias.Changes
{ kind: "forever" }to theUntilSpecunion"forever"(case-insensitive) inparseUntilSpec{ kind: "forever" }to{ substatus: "archived_forever" }inspecToApiOptions— identical to the no---untilpathforeverto the--untilflag brief and the unrecognized-value error hintparseUntilSpec("forever"),parseUntilSpec("Forever")(case-insensitive), and afunc()integration testBefore / After