Skip to content

fix(init): tighten feedback banner copy#933

Merged
betegon merged 1 commit intomainfrom
bt/fix-init-feedback-banner
May 8, 2026
Merged

fix(init): tighten feedback banner copy#933
betegon merged 1 commit intomainfrom
bt/fix-init-feedback-banner

Conversation

@betegon
Copy link
Copy Markdown
Member

@betegon betegon commented May 8, 2026

Summary

Shortens the persistent init footer feedback prompt so it reads like a copyable command. The banner now uses $ sentry cli feedback "what worked or broke" and keeps padding on both edges of the purple footer.

Fix

Reserve a right-padding column when formatting the feedback banner, then update the footer copy to the shorter command-style text. The formatter is exported for a small regression test that checks the banner width and edge padding directly.

Test Plan

bun test test/lib/init/ui/ink-app.snapshot.test.tsx
bunx ultracite check src/lib/init/ui/ink-app.tsx test/lib/init/ui/ink-app.snapshot.test.tsx
bun run typecheck

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

PR Preview Action v1.8.1

QR code for preview link

🚀 View preview at
https://cli.sentry.dev/_preview/pr-933/

Built to branch gh-pages at 2026-05-08 12:53 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

Codecov Results 📊

6836 passed | Total: 6836 | Pass Rate: 100% | Execution Time: 0ms

📊 Comparison with Base Branch

Metric Change
Total Tests 📈 +1
Passed Tests 📈 +1
Failed Tests
Skipped Tests

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 13942 uncovered lines.
❌ Project coverage is 77%. Comparing base (base) to head (head).

Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
- Coverage    77.04%    77.00%    -0.04%
==========================================
  Files          317       317         —
  Lines        60594     60626       +32
  Branches         0         0         —
==========================================
+ Hits         46685     46684        -1
- Misses       13909     13942       +33
- Partials         0         0         —

Generated by Codecov Action

@betegon betegon marked this pull request as ready for review May 8, 2026 13:06
@betegon betegon merged commit 1fd1f8a into main May 8, 2026
27 checks passed
@betegon betegon deleted the bt/fix-init-feedback-banner branch May 8, 2026 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant