fix(install): use correct download URL without 'v' prefix#94
Merged
Conversation
Adds a bash script that downloads and installs the Sentry CLI binary. Supports macOS, Linux, and Windows (via MINGW/MSYS/Cygwin) on x64 and arm64. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
GitHub releases for this repo use version tags without the 'v' prefix (e.g., `0.2.0` not `v0.2.0`). The script was generating URLs like `.../download/v0.2.0/...` which 404'd. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Issue
Other
Bug Fixes 🐛Issue
Other
Documentation 📚
Internal Changes 🔧
Other
🤖 This preview updates automatically when you update the PR. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| Linux*) os="linux" ;; | ||
| MINGW*|MSYS*|CYGWIN*) os="windows" ;; | ||
| *) echo -e "${RED}Unsupported OS: $(uname -s)${NC}"; exit 1 ;; | ||
| esac |
Contributor
There was a problem hiding this comment.
Redundant uname -s call in OS detection
Low Severity
The OS detection block calls uname -s twice: once in the case statement (line 42) and again in the error message (line 46). The architecture detection below correctly captures uname -m into a variable first (arch=$(uname -m)) and reuses it. The OS detection pattern is inconsistent with this approach and results in a redundant system call.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug in the install script where all downloads would 404 because the URL used
v0.2.0instead of0.2.0. GitHub releases for this repo use version tags without thevprefix.Test Plan
🤖 Generated with Claude Code