feat(init): tag wizard.outcome on cli.command span#948
Merged
Conversation
Adds wizard.outcome (completed/bailed/errored), wizard.platform, and wizard.features as Sentry scope tags on the root cli.command span once the remote wizard finishes. Previously span.status was unknown on every init run, making it impossible to filter "failed runs" or "completed runs" in dashboards. These tags give span-level outcome visibility without needing to cross-reference server-side tracemetrics.
Contributor
|
Contributor
Codecov Results 📊✅ 6856 passed | Total: 6856 | Pass Rate: 100% | Execution Time: 0ms 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ❌ Patch coverage is 55.56%. Project has 14006 uncovered lines. Files with missing lines (1)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 76.97% 77.03% +0.06%
==========================================
Files 319 319 —
Lines 60994 60966 -28
Branches 0 0 —
==========================================
+ Hits 46947 46960 +13
- Misses 14047 14006 -41
- Partials 0 0 —Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
span.statusisunknownon everysentry initrun, so there was no way to distinguish completed, bailed, and failed runs in the Init Command dashboard — you just got a sea of identical spans.Adds
wizard.outcome(completed/bailed/errored) as a Sentry scope tag at the three exit paths inrunWizard. On a successful completion also tagswizard.platformandwizard.featuresfrom the final step result, so the CLI span carries the same platform/feature context as the server-side metrics.This unlocks span-level filtering in Explore and dashboards — e.g.
wizard.outcome:erroredfor a "Failed Runs" table,wizard.outcome:completedfor reach-out to successful users.Companion change adding the same tags on the server side: getsentry/cli-init-api#136