fix(plan): only show progress from current step#954
Merged
Conversation
getProgressMessage() walked backwards through all steps and returned the first progress message from any step. During solution polling, this surfaced stale RCA progress messages (e.g. 'Looking at src/mdx.ts') because the completed RCA step still had progress entries while the new solution step had none yet. Now only looks at the last step (current phase) and falls back to a status-based message when it has no progress. Fixes #950
Contributor
|
Contributor
Codecov Results 📊✅ 6858 passed | Total: 6858 | Pass Rate: 100% | Execution Time: 0ms 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 80.00%. Project has 14030 uncovered lines. Files with missing lines (1)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
- Coverage 77.04% 77.00% -0.04%
==========================================
Files 319 319 —
Lines 60950 60988 +38
Branches 0 0 —
==========================================
+ Hits 46956 46958 +2
- Misses 13994 14030 +36
- Partials 0 0 —Generated by Codecov Action |
Member
Author
|
All 18 CI checks passed (unit tests, e2e, lint, typecheck, build, CodeQL, semgrep). Self-review confirmed the fix is correctly scoped — only |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getProgressMessage()walked backwards through all autofix steps and returned the first progress message found from any step. During solution polling after RCA completes, this surfaced stale RCA messages (e.g. "Looking atsrc/mdx.ts...") because the completed RCA step still had progress entries while the new solution step had none yet.Now only reads progress from the last (current) step and falls back to a status-based message when it has no progress.
Testing
bun test test/lib/formatters/seer.test.ts— 40 tests pass, including two new tests for the exact scenario from the issue.Fixes #950