Skip to content

fix(plan): only show progress from current step#954

Merged
MathurAditya724 merged 1 commit into
mainfrom
issue-950-fix-stale-rca-progress
May 12, 2026
Merged

fix(plan): only show progress from current step#954
MathurAditya724 merged 1 commit into
mainfrom
issue-950-fix-stale-rca-progress

Conversation

@MathurAditya724
Copy link
Copy Markdown
Member

getProgressMessage() walked backwards through all autofix steps and returned the first progress message found from any step. During solution polling after RCA completes, this surfaced stale RCA messages (e.g. "Looking at src/mdx.ts...") because the completed RCA step still had progress entries while the new solution step had none yet.

Now only reads progress from the last (current) step and falls back to a status-based message when it has no progress.

Testing

bun test test/lib/formatters/seer.test.ts — 40 tests pass, including two new tests for the exact scenario from the issue.

Fixes #950

getProgressMessage() walked backwards through all steps and returned
the first progress message from any step. During solution polling,
this surfaced stale RCA progress messages (e.g. 'Looking at src/mdx.ts')
because the completed RCA step still had progress entries while the
new solution step had none yet.

Now only looks at the last step (current phase) and falls back to a
status-based message when it has no progress.

Fixes #950
@github-actions
Copy link
Copy Markdown
Contributor

PR Preview Action v1.8.1

QR code for preview link

🚀 View preview at
https://cli.sentry.dev/_preview/pr-954/

Built to branch gh-pages at 2026-05-11 22:40 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@github-actions
Copy link
Copy Markdown
Contributor

Codecov Results 📊

6858 passed | Total: 6858 | Pass Rate: 100% | Execution Time: 0ms

📊 Comparison with Base Branch

Metric Change
Total Tests 📈 +2
Passed Tests 📈 +2
Failed Tests
Skipped Tests

All tests are passing successfully.

✅ Patch coverage is 80.00%. Project has 14030 uncovered lines.
❌ Project coverage is 77%. Comparing base (base) to head (head).

Files with missing lines (1)
File Patch % Lines
src/lib/formatters/seer.ts 80.00% ⚠️ 1 Missing
Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
- Coverage    77.04%    77.00%    -0.04%
==========================================
  Files          319       319         —
  Lines        60950     60988       +38
  Branches         0         0         —
==========================================
+ Hits         46956     46958        +2
- Misses       13994     14030       +36
- Partials         0         0         —

Generated by Codecov Action

@MathurAditya724 MathurAditya724 marked this pull request as ready for review May 12, 2026 04:00
@MathurAditya724
Copy link
Copy Markdown
Member Author

All 18 CI checks passed (unit tests, e2e, lint, typecheck, build, CodeQL, semgrep). Self-review confirmed the fix is correctly scoped — only getProgressMessage() changed, no regression for the explain flow since single-step RCA still works via steps.at(-1). Two new tests cover the exact bug scenario from #950. Marking ready for review.

@MathurAditya724 MathurAditya724 merged commit 3f89b84 into main May 12, 2026
26 checks passed
@MathurAditya724 MathurAditya724 deleted the issue-950-fix-stale-rca-progress branch May 12, 2026 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

plan: stale RCA progress shown during solution polling

1 participant