Skip to content

refactor: migrate test runner from bun:test to vitest#997

Merged
BYK merged 1 commit into
mainfrom
refactor/vitest-migration-v2
May 21, 2026
Merged

refactor: migrate test runner from bun:test to vitest#997
BYK merged 1 commit into
mainfrom
refactor/vitest-migration-v2

Conversation

@BYK
Copy link
Copy Markdown
Member

@BYK BYK commented May 21, 2026

Phase 3 of the Bun to Node.js migration. Migrates 327 test files from bun:test to vitest. 306/307 test files pass, 6994/7014 tests pass, 0 failures. See closed PR #992 for full description.

Comment thread src/lib/list-command.ts
Comment thread test/commands/dashboard/list.test.ts
@BYK BYK force-pushed the refactor/vitest-migration-v2 branch from 2a7e6d7 to 654dbfa Compare May 21, 2026 14:06
Comment thread src/lib/db/sqlite.ts
@BYK BYK enabled auto-merge (squash) May 21, 2026 14:18
@BYK BYK force-pushed the refactor/vitest-migration-v2 branch from 654dbfa to 0c40bb4 Compare May 21, 2026 14:18
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 21, 2026

PR Preview Action v1.8.1

QR code for preview link

🚀 View preview at
https://cli.sentry.dev/_preview/pr-997/

Built to branch gh-pages at 2026-05-21 17:45 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Comment thread src/lib/list-command.ts
@BYK BYK force-pushed the refactor/vitest-migration-v2 branch 6 times, most recently from 611afc6 to f282c8c Compare May 21, 2026 15:11
Comment thread .github/workflows/ci.yml Outdated
@BYK BYK force-pushed the refactor/vitest-migration-v2 branch 3 times, most recently from e822703 to 6a83e7c Compare May 21, 2026 15:40
Comment thread .github/workflows/ci.yml Outdated
@BYK BYK force-pushed the refactor/vitest-migration-v2 branch 2 times, most recently from 978f44e to a318ec2 Compare May 21, 2026 16:09
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit a318ec2. Configure here.

Comment thread .github/workflows/ci.yml
@BYK BYK force-pushed the refactor/vitest-migration-v2 branch 3 times, most recently from d2ed573 to a5a6e5c Compare May 21, 2026 16:43
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 21, 2026

Codecov Results 📊

✅ Patch coverage is 81.63%. Project has 4287 uncovered lines.
✅ Project coverage is 81.63%. Comparing base (base) to head (head).

Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    76.35%    81.63%    +5.28%
==========================================
  Files          328       328         —
  Lines        63962     23341    -40621
  Branches         0     15109    +15109
==========================================
+ Hits         48839     19054    -29785
- Misses       15123      4287    -10836
- Partials         0      1614     +1614

Generated by Codecov Action

@BYK BYK force-pushed the refactor/vitest-migration-v2 branch 4 times, most recently from cd52859 to 2b07a74 Compare May 21, 2026 17:33
@BYK BYK force-pushed the refactor/vitest-migration-v2 branch from 2b07a74 to 1c821c4 Compare May 21, 2026 17:44
Comment thread test/mocks/server.ts
@BYK BYK merged commit 5e19e7c into main May 21, 2026
30 checks passed
@BYK BYK deleted the refactor/vitest-migration-v2 branch May 21, 2026 17:52
betegon added a commit that referenced this pull request May 22, 2026
…gration

vitest requires .rejects.toThrow() to be awaited; bun:test did not.
The missing await at the 404 test caused "expected undefined to be
defined" in CI after PR #997 landed.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant