Skip to content

ci: Use correct artifact name for dogfooding#742

Merged
BYK merged 1 commit intomasterfrom
fix/action-artifact-name
Feb 6, 2026
Merged

ci: Use correct artifact name for dogfooding#742
BYK merged 1 commit intomasterfrom
fix/action-artifact-name

Conversation

@BYK
Copy link
Member

@BYK BYK commented Feb 6, 2026

Summary

Fixes release workflow failure caused by artifact name mismatch.

The download-artifact step in action.yml was looking for an artifact named with the commit SHA (${{ github.sha }}), but build.yml uploads the artifact as craft-binary.

Changes

  • Updated action.yml to download artifact by name craft-binary instead of ${{ github.sha }}

Related

The download-artifact step was looking for an artifact named with the
commit SHA (${{ github.sha }}), but build.yml uploads the artifact as
'craft-binary'. This mismatch caused release failures with:

  Artifact not found for name: <commit-sha>

Update the artifact name to 'craft-binary' to match the upload step.
@BYK BYK marked this pull request as ready for review February 6, 2026 17:10
@BYK BYK changed the title fix(action): Use correct artifact name for dogfooding ci: Use correct artifact name for dogfooding Feb 6, 2026
@BYK BYK merged commit e9fd6aa into master Feb 6, 2026
19 of 21 checks passed
@BYK BYK deleted the fix/action-artifact-name branch February 6, 2026 17:25
BYK added a commit that referenced this pull request Feb 6, 2026
## Summary

Fixes publishing failure when using the currently released Craft
version.

The older Craft version uses legacy artifact lookup where `artifact.name
=== commit SHA`. Since we renamed artifacts to `craft-binary` and
`craft-docs`, publishing fails because it can't find an artifact named
with the commit SHA.

## Changes

- Upload an additional artifact with the commit SHA name for backward
compatibility
- This allows the release to be published with the current Craft version

## Notes

This can be removed after 2.21.0 is released since the new version
supports the named artifacts approach.

## Related

- Previous fix: #742
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant