fix(action): Handle permission errors when updating publish issues#744
Merged
fix(action): Handle permission errors when updating publish issues#744
Conversation
The GitHub App token may not have permission to update issues in the publish repo (getsentry/publish). Handle this gracefully by catching the error and continuing with the existing issue URL instead of failing the entire release workflow.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| if gh issue edit "$existing_issue_number" -R "$PUBLISH_REPO" --body "$body" 2>/dev/null; then | ||
| echo "::notice::Updated existing publish request: ${existing_issue_url}" | ||
| else | ||
| echo "::warning::Could not update existing issue (permission denied). Using existing issue as-is." |
Contributor
There was a problem hiding this comment.
All errors silently treated as permission errors
Medium Severity
The gh issue edit command's stderr is redirected to /dev/null, suppressing all error output, while the warning message assumes any failure is due to "permission denied". The command could fail for many other reasons (network issues, rate limiting, expired token, deleted issue, etc.), but the actual error is lost and a misleading message is shown instead. This makes debugging difficult when non-permission errors occur.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes release workflow failure when the GitHub App token doesn't have permission to update issues in the publish repo.
Problem
The release workflow failed with:
The
sentry-release-botGitHub App can create issues ingetsentry/publishbut cannot update them.Solution
Handle the permission error gracefully:
Related