Skip to content

fix(security): Move workflow to pull_request and do not persist creds #796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BYK merged 1 commit into from
Apr 21, 2026
+7 −6
Merged

fix(security): Move workflow to pull_request and do not persist creds #796

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions .github/workflows/changelog-preview.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,17 +70,16 @@ on:
default: true

# Also run on PRs in this repository (dogfooding)
pull_request_target:
pull_request:
types: [opened, synchronize, reopened, edited, labeled, unlabeled]

permissions:
contents: read
pull-requests: write # For comment mode
statuses: write # For status check mode

jobs:
preview:
runs-on: ubuntu-latest
permissions:
contents: read
pull-requests: write # For comment mode
statuses: write # For status check mode
steps:
# For pull_request_target, we must explicitly specify the ref to get the PR commits.
# Try the merge ref first; fall back to head ref if PR has merge conflicts.
Expand All @@ -90,12 +89,14 @@ jobs:
with:
fetch-depth: 0
ref: refs/pull/${{ github.event.pull_request.number }}/merge
persist-credentials: false

- uses: actions/checkout@v6
if: steps.checkout-merge.outcome == 'failure'
with:
fetch-depth: 0
ref: ${{ github.event.pull_request.head.sha }}
persist-credentials: false

- name: Install Craft
shell: bash
Expand Down
Loading