fix(security): Prevent script injection in changelog-preview workflow#813
Merged
Conversation
Move github.event.pull_request.head.sha from direct interpolation to environment variable to prevent potential script injection attacks. Fixes: https://linear.app/getsentry/issue/VULN-1637 Fixes: https://linear.app/getsentry/issue/DI-1918 Co-Authored-By: fix-it-felix-sentry[bot] <260785270+fix-it-felix-sentry[bot]@users.noreply.github.com>
BYK
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a high-severity security finding by preventing potential script injection in the changelog-preview GitHub Actions workflow.
Changes
Moved
github.event.pull_request.head.shafrom direct interpolation in the shell script to an environment variable. This follows GitHub's security best practices for handling untrusted context data.Before:
After:
Security Impact
Direct interpolation of GitHub context data in shell scripts can allow attackers to inject malicious code. By using an intermediate environment variable, the value is safely escaped and prevents script injection attacks.
References