feat: implement CrashpadClient::Add/RemoveAttachment() for macOS#153
Open
feat: implement CrashpadClient::Add/RemoveAttachment() for macOS#153
Conversation
jpnurmi
force-pushed
the
feat/add-remove-attachment-mac
branch
from
b0ffb50 to
36e473f
Compare
mujacica
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add macOS add/remove attachment control messages, using the existing
ClientToServerMessageprotocol added in #147.This mirrors the dynamic attachment support originally added for Windows and Linux in #124, and allows us to deprecate the configure-time
sentry_options_add_view_hierarchyin favor of the more flexiblesentry_attachment_set_typeproposed in getsentry/sentry-native#1700.Tested by:
Indirectly required for: