This repository was archived by the owner on Aug 14, 2024. It is now read-only.
feat: Add from/to traceparent #147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sentry/develop/gyc6hp2qx/sentry.dev |
rhcarvalho
reviewed
Sep 23, 2020
| - `SpanContext` is the attribute collection for a `Span` (Can be an implementation detail) | ||
| - The relation between parent - child is captured in the property `parentSpanId` | ||
| - `Span` should have a method called `toTraceparent` which returns a string `sentry-trace` that could be sent as a header | ||
| - Similar `SpanContext` should have a static method called `fromTraceparent` which prefills a `SpanContext` with data received from a `sentry-trace` string |
Contributor
There was a problem hiding this comment.
SpanContextis an implementation detail, as indicated above, so I'd not define required methods on it.from/toTraceparentshould be inSpanandTransaction. JS defines both methods onSpanand they are inherited byTransaction.- We need to document the format of the string used for the
sentry-traceheader.
Member
Author
There was a problem hiding this comment.
I would say SpanContext while implementation detail we can come with an opinion to have this there.
rhcarvalho
reviewed
Sep 23, 2020
Co-authored-by: Rodolfo Carvalho <rodolfo.carvalho@sentry.io>
rhcarvalho
approved these changes
Sep 24, 2020
Contributor
rhcarvalho
left a comment
rhcarvalho
left a comment
There was a problem hiding this comment.
Thanks for filling in the gaps :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up in this PR and in Discord
getsentry/sentry-php#1092
We should document to have this.