This repository was archived by the owner on Aug 14, 2024. It is now read-only.
Feat: Update Search to better handle zero-hit results#336
Merged
Conversation
cameronmcefee
commented
May 10, 2021
cameronmcefee
commented
Contributor
- When results for same site, show results + "show other sites" button
- When no results, automatically start showing results for other sites
- If no results for any site, show no-results view
- When the user clears the input, reset the state of the search bar
- Don't search single character queries
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sentry/develop/GouHhz6C91UYBo3ZsdvxzDSREMiH |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.