fix: ignore_cleanup_errors to mitigate strange flakes in sentry CI#312
Merged
fix: ignore_cleanup_errors to mitigate strange flakes in sentry CI#312
Conversation
mchen-sentry
approved these changes
Apr 27, 2026
3 tasks
joshuarli
added a commit
to getsentry/sentry
that referenced
this pull request
Apr 28, 2026
still messed up here: https://github.com/getsentry/sentry/actions/runs/25064614491/job/73428196070 was hoping getsentry/devservices#312 would have fixed things but nope this is the more nuclear option
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
edit: here's a failing job https://github.com/getsentry/sentry/actions/runs/25004348752/job/73222906040 which is using runner version 20260426.100
https://github.com/actions/runner-images/releases/tag/ubuntu24/20260426.100
git got upgraded to 2.54.0
claude says: Git 2.54.0's geometric repacking default means
gc.auto (which fires in the background after fetch/clone) now creates more
files in .git/objects/pack/ — MIDX layers, bitmap files, incremental packs
— compared to 2.53.0. If this background gc process creates any of those
files after Python's shutil.rmtree has already scanned the directory but
before the final os.rmdir('.git'), you get ENOTEMPTY. The race window is
small, hence the flakiness rather than consistent failure.
not really sure what's going on here but my best guess is github upgraded/reconfigured git on their runner images to do more background repo bookkeeping stuff and that's racing with python's tempdir cleanup
mitigate this; it's not a symptom of anything bad happening, and it's fine if the dirs aren't completely cleaned up since it's part of an ephemeral job anyway