Make gocd-pipelines functions consistent and re-usable#45
Merged
mattgauntseo-sentry merged 3 commits intomainfrom Sep 11, 2023
Merged
Make gocd-pipelines functions consistent and re-usable#45mattgauntseo-sentry merged 3 commits intomainfrom
mattgauntseo-sentry merged 3 commits intomainfrom
Conversation
IanWoodard
approved these changes
Sep 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed an issue when trying to roll this out to getsentry.
The
pipelines_to_files_objectandpipelines_to_objectwere inconsistent in what they did, files_object would includeformat: 10, pipelines: ...to the output making it valid to GoCD while thepipeliens_to_objectwould just return the pipelines which is invalid.This corrects that, making both of them output valid GoCD pipelines