test(dashboard): pin fake timers in mock routes test#520
Merged
Conversation
The mock reporting fixture uses hardcoded session dates around 2026-05-29. recentConversationGroups filters sessions older than 7 days from Date.now(), so the test began failing once the wall clock passed that threshold. Pin time with vi.useFakeTimers so the fixture stays within the stats window. Co-authored-by: U039RR91S <noreply>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 84024a3. Configure here.
Co-authored-by: U039RR91S <noreply>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
overlays mock conversations for local dashboard visual QAtest began failing after 2026-06-05 — 7 days past the hardcoded session dates in the mock reporting fixture.recentConversationGroupsfilters sessions older than 7 days fromDate.now(). The test's fixture useslastSeenAt: "2026-05-29T00:00:01.000Z", which fell outside the window once the wall clock advanced past that threshold.Fix
Pin
Date.now()viavi.useFakeTimers({ now: new Date("2026-05-29T00:00:00.000Z") })in the failing test. The existingafterEach(() => vi.useRealTimers())already handles cleanup.The same fix was applied to
release/0.67.0in-place to unblock the pending release.Refs: pre-existing failure introduced in
52e49e02(feat(dashboard): Add plugin and conversation stats).View Session in Sentry