feat(identity): Add SQL-backed people API#738
Merged
Conversation
Add a shared user identity table linked from verified provider identities, and have conversation writes upsert trusted requester identities by normalized email. Move people list/profile reads out of JuniorReporting into per-endpoint Drizzle API modules consumed by the dashboard, with route and SQL integration tests covering case-insensitive lookup and verified-email filtering. Co-Authored-By: GPT-5 Codex <codex@openai.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 840ab82. Configure here.
Fill a missing shared user display name from later verified identity observations without replacing an existing value. Cover the case through the SQL-backed people profile integration test so names stay visible after the first email-only observation. Co-Authored-By: GPT-5 Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
People list and profile now read from a durable SQL identity model instead of JuniorReporting or turn-session summaries. Conversation writes upsert verified provider identities into
junior_usersby normalized email, so trusted Slack requester observations share one user identity case-insensitively.The dashboard mounts per-endpoint people API wrappers over
@sentry/junior/api/people/listand/profile, while plugin reporting remains the extension point for plugin APIs. The public people subpaths expose only the read APIs; source-local query helpers keep integration tests on real Drizzle fixtures.Review order: start with the identity schema/migration and
upsertIdentity, then the people API endpoints and dashboard route wrappers, then the reporting/test deletions.