Add ZippedApk artifact#24
Merged
Merged
Conversation
rbro112
force-pushed
the
ryan/zipped_apk_artifact
branch
from
1635362 to
f7f414e
Compare
rbro112
commented
Jun 12, 2025
trevor-e
approved these changes
Jun 13, 2025
| app_info=app_info, | ||
| ) | ||
|
|
||
| def _artifact_from_path(self, path: Path) -> AndroidArtifact: |
Member
There was a problem hiding this comment.
Same I'd expect this to be a method on AndroidArtifact, not in here.
Member
Author
There was a problem hiding this comment.
Can't live in AndroidArtifact due to circular dependencies but created a new ArtifactFactory class and moved into there, and also added support for iOS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows us to parse uploads from the Sentry CLI (normalized to be zipped).