Skip to content

Make artifact_factory.py more memory efficient#311

Merged
NicoHinderling merged 2 commits into
mainfrom
optimize-artifact-factory
Sep 2, 2025
Merged

Make artifact_factory.py more memory efficient#311
NicoHinderling merged 2 commits into
mainfrom
optimize-artifact-factory

Conversation

@NicoHinderling

@NicoHinderling NicoHinderling commented Sep 2, 2025

Copy link
Copy Markdown
Contributor

changes:

  1. Only read 4 bytes into memory rather than the whole file
  2. Open ZIP file directly from path instead of loading into memory

@codecov

codecov Bot commented Sep 2, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.75%. Comparing base (b66c16e) to head (805b188).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #311      +/-   ##
==========================================
- Coverage   77.75%   77.75%   -0.01%     
==========================================
  Files         142      142              
  Lines       11149    11148       -1     
  Branches     1185     1185              
==========================================
- Hits         8669     8668       -1     
  Misses       2059     2059              
  Partials      421      421              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread src/launchpad/artifacts/artifact_factory.py Outdated
@NicoHinderling NicoHinderling merged commit bdfc2a0 into main Sep 2, 2025
18 checks passed
@NicoHinderling NicoHinderling deleted the optimize-artifact-factory branch September 2, 2025 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants