Skip to content

Add "optimize alternative icons" insight handling #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NicoHinderling merged 3 commits into from
Oct 15, 2025

get rid of logger.error in image_optimization.py too

9236935
Select commit
Loading
Failed to load commit list.
Merged

Add "optimize alternative icons" insight handling #417

get rid of logger.error in image_optimization.py too
9236935
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 15, 2025 in 0s

79.96% (+0.18%) compared to 7683d66

View this Pull Request on Codecov

79.96% (+0.18%) compared to 7683d66

Details

Codecov Report

❌ Patch coverage is 89.52381% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.96%. Comparing base (7683d66) to head (9236935).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...aunchpad/size/insights/apple/image_optimization.py 75.60% 9 Missing and 1 partial ⚠️
src/launchpad/artifacts/apple/zipped_xcarchive.py 56.25% 4 Missing and 3 partials ⚠️
...ize/insights/apple/alternate_icons_optimization.py 92.85% 2 Missing and 1 partial ⚠️
tests/unit/test_alternate_icons_optimization.py 98.11% 0 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #417      +/-   ##
==========================================
+ Coverage   79.77%   79.96%   +0.18%     
==========================================
  Files         147      149       +2     
  Lines       11850    12027     +177     
  Branches     1208     1223      +15     
==========================================
+ Hits         9453     9617     +164     
- Misses       1962     1969       +7     
- Partials      435      441       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov