Skip to content

feat(ios): parse the archive plist's CreationDate field#475

Merged
trevor-e merged 4 commits intomainfrom
telkins/ios-date-built
Nov 14, 2025
Merged

feat(ios): parse the archive plist's CreationDate field#475
trevor-e merged 4 commits intomainfrom
telkins/ios-date-built

Conversation

@trevor-e
Copy link
Member

@trevor-e trevor-e commented Nov 14, 2025

Resolves EME-632

@linear
Copy link

linear bot commented Nov 14, 2025

EME-632 iOS date_built

if archive_plist:
creation_date = archive_plist.get("CreationDate")
if creation_date:
build_date = creation_date.isoformat()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I think this could also be written as

plist = xcarchive.get_archive_plist() or {}
date = plist.get("CreationDate")
build_date = date.isoformat() if date else None

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the if creation_date: branch but keeping the if archive_plist: check, would rather not default to or {} in this case.

@codecov
Copy link

codecov bot commented Nov 14, 2025

Codecov Report

❌ Patch coverage is 67.85714% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.53%. Comparing base (416af31) to head (5e7168d).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/launchpad/artifacts/apple/zipped_xcarchive.py 57.89% 6 Missing and 2 partials ⚠️
src/launchpad/size/analyzers/apple.py 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #475      +/-   ##
==========================================
- Coverage   80.56%   80.53%   -0.03%     
==========================================
  Files         161      161              
  Lines       13644    13672      +28     
  Branches     1448     1451       +3     
==========================================
+ Hits        10992    11011      +19     
- Misses       2111     2117       +6     
- Partials      541      544       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@trevor-e trevor-e merged commit fabe8d8 into main Nov 14, 2025
21 checks passed
@trevor-e trevor-e deleted the telkins/ios-date-built branch November 14, 2025 22:08
@sentry
Copy link
Contributor

sentry bot commented Nov 14, 2025

Issues attributed to commits in this pull request

This pull request was merged and Sentry observed the following issues:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants