feat(ios): parse the archive plist's CreationDate field#475
Merged
Conversation
NicoHinderling
approved these changes
Nov 14, 2025
| if archive_plist: | ||
| creation_date = archive_plist.get("CreationDate") | ||
| if creation_date: | ||
| build_date = creation_date.isoformat() |
Contributor
There was a problem hiding this comment.
nit: I think this could also be written as
plist = xcarchive.get_archive_plist() or {}
date = plist.get("CreationDate")
build_date = date.isoformat() if date else None
Member
Author
There was a problem hiding this comment.
Removed the if creation_date: branch but keeping the if archive_plist: check, would rather not default to or {} in this case.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #475 +/- ##
==========================================
- Coverage 80.56% 80.53% -0.03%
==========================================
Files 161 161
Lines 13644 13672 +28
Branches 1448 1451 +3
==========================================
+ Hits 10992 11011 +19
- Misses 2111 2117 +6
- Partials 541 544 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Issues attributed to commits in this pull requestThis pull request was merged and Sentry observed the following issues: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves EME-632