fix: check segment name when matching symbol neighbors #558
+53
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trevor-e
commented
Jan 30, 2026
| same_section = ( | ||
| next_sym_section | ||
| and next_sym_section.segment | ||
| and next_sym_section.segment.name == section.segment.name |
Member
Author
There was a problem hiding this comment.
This is the core fix, we had a case where a symbol got compared to a section in a different segment.
trevor-e
commented
Jan 30, 2026
| address=data.address, | ||
| size=data.size, | ||
| ) | ||
| symbol_sizes = [ |
Member
Author
There was a problem hiding this comment.
There's some light cleanup mixed in here as well, left a comment on the bug fix.
NicoHinderling
approved these changes
Jan 30, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a bug where in some rare cases we would compare a symbol to a neighbor in a different segment, which in this case produced a negative symbol size and caused a pydantic validation error. Now we ensure only symbols within the same segment are compared since some sections can have colliding names.
Tested the affected customer build and our hackernews fixture and seems correct.
https://sentry.sentry.io/issues/7215094878/events/c311e7b4e31a4ff98783579d17c581b9/#logs