fix(workflows): Drop injectable args, let sentry-cli auto-detect VCS#608
Merged
runningcode merged 3 commits intomainfrom Apr 29, 2026
Merged
fix(workflows): Drop injectable args, let sentry-cli auto-detect VCS#608runningcode merged 3 commits intomainfrom
runningcode merged 3 commits intomainfrom
Conversation
Alternate fix to #607. The sentry_dogfood workflow was passing head-sha, base-sha, vcs-provider, head/base-repo-name, head/base-ref, and pr-number explicitly via ${{ github.* }} interpolations, which created a script injection vector. Rather than moving those values into env: blocks, drop them entirely: sentry-cli's collect_git_metadata auto-detects every one of these from GitHub Actions env vars and GITHUB_EVENT_PATH when is_ci() is true. The auth token is also picked up from SENTRY_AUTH_TOKEN, so no flag is needed for it either. Removes the entire pull_request/push branching and every untrusted interpolation from run: blocks, eliminating the injection vector by construction. Linear: https://linear.app/getsentry/issue/VULN-1590
Contributor
📲 Install BuildsiOS
Android
|
cameroncooke
approved these changes
Apr 29, 2026
Contributor
cameroncooke
left a comment
cameroncooke
left a comment
There was a problem hiding this comment.
Much better, thanks @runningcode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Alternate fix to #607 for the script injection vulnerability in the Sentry Dogfood workflow.
Rather than moving every
${{ github.* }}interpolation into anenv:block, this PR removes the arguments entirely.sentry-cli'scollect_git_metadataauto-detects all of them when running in CI.This eliminates the injection vector by construction — there is no untrusted input in any
run:block — and collapses the workflow from ~95 lines of conditional branching to ~14 lines of straight-line invocation.Related
🤖 Generated with Claude Code