ref(server): Use "correct" methods and status codes for creation#215
Merged
ref(server): Use "correct" methods and status codes for creation#215
Conversation
Swatinem
approved these changes
Nov 19, 2025
jan-auer
force-pushed
the
ref/put-status-codes
branch
from
5e25d22 to
2d6f579
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating an object with or without a key usually uses different HTTP
verbs. PUT writes or overrides an object at a known key, while POST
always adds a new object with a server-defined key. The status codes
also differ, with POST returning 201 CREATED.
If we think this is useful, we could also make PUT return 201, but for
that we'd have to return from the backend whether the object previously
existed.
Internally, we now have two types:
ObjectPathrequires a key to be present. It is used for GET andDELETE.
OptionalObjectPathhas an optional key. It can be converted intoObjectPath, either requiring or creating a random key.ObjectPath deserializes via OptionalObjectPath.