Skip to content

feat(clients): Append to the given base URL path #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 26, 2025
Merged

feat(clients): Append to the given base URL path #222

merged 6 commits into from
Nov 26, 2025

Conversation

@lcian
Copy link
Member

@lcian lcian commented Nov 24, 2025 •
edited
Loading

  • Append to base URL
  • Keep the headers set on the urllib pool, previously we would replace them with ours

This is needed for the proxy in the monolith.

@lcian lcian marked this pull request as ready for review November 24, 2025 15:42
@lcian lcian requested a review from a team as a code owner November 24, 2025 15:42
sentry[bot]
sentry bot reviewed Nov 24, 2025
View reviewed changes
@lcian lcian changed the title feat(py-client): Consider the given base URL and don't override headers feat(clients): Consider the given base URL Nov 25, 2025
@lcian lcian changed the title feat(clients): Consider the given base URL feat(clients): Consider the given base URL path Nov 25, 2025
@lcian lcian changed the title feat(clients): Consider the given base URL path feat(clients): Append to the given base URL path Nov 25, 2025
sentry[bot]
sentry bot reviewed Nov 25, 2025
View reviewed changes
jan-auer
jan-auer approved these changes Nov 25, 2025
View reviewed changes
@lcian lcian requested a review from jan-auer November 25, 2025 18:33
Swatinem
Swatinem approved these changes Nov 26, 2025
View reviewed changes
sentry[bot]
sentry bot reviewed Nov 26, 2025
View reviewed changes
@lcian lcian merged commit e840bb8 into main Nov 26, 2025
19 checks passed
@lcian lcian deleted the lcian/feat/py-client-base-url branch November 26, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jan-auer jan-auer Awaiting requested review from jan-auer

2 more reviewers

@sentry sentry[bot] sentry[bot] left review comments

@Swatinem Swatinem Swatinem approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lcian @Swatinem @jan-auer