feat(service): Add concurrency limit to StorageService#324
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
jan-auer
commented
Feb 20, 2026
| /// | ||
| /// This value is used when no explicit limit is set via | ||
| /// [`StorageService::with_concurrency_limit`]. | ||
| pub const DEFAULT_CONCURRENCY_LIMIT: usize = 500; |
Member
Author
There was a problem hiding this comment.
This default is chosen arbitrarily so that it is not unreasonably high, but still high enough to not limit in practice. We will tweak this.
matt-codecov
approved these changes
Feb 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #322 (task spawning with panic isolation).
Adds a semaphore-based concurrency limit to
StorageServicethat caps the total number of in-flight backend operations. When the limit is reached, new operations are rejected immediately with HTTP 429 rather than queueing, preventing backend overload during traffic bursts.The limit is acquired before spawning each operation task and the permit is held until the task completes (including after panics). Configured via
service.max_concurrency(default: 500, effectively unlimited without configuration).Includes tests for rejection at capacity and permit release after panics.
Next steps
InFlightRequestsLayer. Excludes health/ready endpoints.tokio::spawnwith a bounded channel dispatching to a fixed worker pool, enabling backpressure, fire-and-forget operations, and priority scheduling.CancellationTokento actively cancel backend operations on client disconnect, with safety invariants protecting tombstone writes from cancellation.Ref FS-171